Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-ceph: add Ceph Reef CI jobs #907

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Conversation

phlogistonjohn
Copy link
Collaborator

With the Ceph Reef release imminent, we're a bit overdue to add it to our CI. However, the risk of being a little late is lowered by the fact that we have our tests regularly running against ceph main branch.

However, once the release is done the divergence between the two will increase over time and so I think it's good to get this done soon.

@phlogistonjohn phlogistonjohn changed the title [WIP] go-ceph: add Ceph Reef CI jobs go-ceph: add Ceph Reef CI jobs Aug 1, 2023
@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Aug 1, 2023
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Mergify configuration? Are you planning to update in a separate PR?

@phlogistonjohn
Copy link
Collaborator Author

What about Mergify configuration? Are you planning to update in a separate PR?

Yes. In this case we'd only be adding reef as the pre-* jobs are not required now and I'm not planning on changing that.

Reef is a valid target for testing fsadmin.

Signed-off-by: John Mulligan <[email protected]>
Add CEPH_VERSION values for reef and pre-reef. This will allow building
and testing with ceph reef images.

Signed-off-by: John Mulligan <[email protected]>
As reef is being added and there's very little activity going into
pacific now, it should be safe to stop testing pre-pacific.

Signed-off-by: John Mulligan <[email protected]>
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@mergify mergify bot merged commit a495ff9 into ceph:master Aug 2, 2023
12 of 13 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-reef branch August 2, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants