-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling and fix a crash #65
Conversation
Your Render PR Server URL is https://pulpito-ng-pr-65.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ckpcnje2eoec73e8ebeg. |
✅ Deploy Preview for pulpito ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I just noticed that we didn't merge this PR, sorry. This looks like a useful feature to have, so we can merge it and text wrap can be a low hanging fruit for later (probably shouldn't hold important PR approvals for text-wraps haha!). I'll approve this after the needed rebase - already tested locally. |
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
And wrap both the main app body and the DataGrid component with it. Signed-off-by: Zack Cerza <[email protected]>
Paddles should not give us broken job objects like this, but we should also not crash if it does :) Signed-off-by: Zack Cerza <[email protected]>
@VallariAg rebased! |
This is the page where I first noticed this crash: https://pulpito-ng.ceph.com/runs/mchangir-2023-10-14_16:12:46-fs-wip-mchangir-mgr-snap_schedule-support-subvol-and-group-arguments-distro-default-smithi