Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication callback #12

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Authentication callback #12

merged 7 commits into from
Sep 11, 2023

Commits on Aug 31, 2023

  1. Login callback: redirect to pulpito with session cookies 

    Signed-off-by: Vallari <[email protected]>
    @VallariAg
    VallariAg committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    79c2cdf View commit details
    Browse the repository at this point in the history

  2. main: change 'allow_origins' from * to URLs 

    To send cross site requests from pulpito-ng with `withCredentials`,
the server cannot have `*` as allowed origins.

Signed-off-by: Vallari <[email protected]>
    @VallariAg
    VallariAg committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    c22ea9e View commit details
    Browse the repository at this point in the history

  3. fix cookie_data.items() error 

    Signed-off-by: Vallari <[email protected]>
    @VallariAg
    VallariAg committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    50ff7d0 View commit details
    Browse the repository at this point in the history

  4. add .env.dev 

    Signed-off-by: Vallari <[email protected]>
    @VallariAg
    VallariAg committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    b1e4ea7 View commit details
    Browse the repository at this point in the history

  5. add avatar_url in /login response and redirect /logout to pulpito-ng 

    Signed-off-by: Vallari <[email protected]>
    @VallariAg
    VallariAg committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    2deffd6 View commit details
    Browse the repository at this point in the history

  6. login: add error handling for missing env variable 

    Signed-off-by: Vallari Agrawal <[email protected]>
    @VallariAg
    VallariAg committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    315dbc7 View commit details
    Browse the repository at this point in the history

  7. README: add instructions to configure github oauth 

    And add random value of SESSION_SECRET_KEY in .env.dev

Signed-off-by: Vallari Agrawal <[email protected]>
    @VallariAg
    VallariAg committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    aa04615 View commit details
    Browse the repository at this point in the history