Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/routes: Update pydantic dict() to model_dump() #16

Merged
merged 1 commit into from
Sep 13, 2023
Merged

src/routes: Update pydantic dict() to model_dump() #16

merged 1 commit into from
Sep 13, 2023

Conversation

Devansh3712
Copy link
Member

.dict() method for converting a pydantic BaseModel to a dictionary is deprecated. This PR updates it to the new method, .model_dump()

VallariAg
VallariAg approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@VallariAg VallariAg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Rebase the branch to main to pass all checks.

@Devansh3712
Copy link
Member Author

LGTM! Rebase the branch to main to pass all checks.

alright, will do

@VallariAg VallariAg merged commit ce06731 into ceph:main Sep 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VallariAg VallariAg VallariAg approved these changes

@kamoltat kamoltat Awaiting requested review from kamoltat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Devansh3712 @VallariAg