Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure developement setup for docker #22

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Configure developement setup for docker #22

merged 1 commit into from
Oct 18, 2023

Conversation

VallariAg
Copy link
Member

@VallariAg VallariAg commented Sep 12, 2023

  • use TEUTHOLOGY_API_SERVER_HOST and TEUTHOLOGY_API_SERVER_PORT when starting the server to map host and port
  • add start_container.sh
  • if DEPLOYMENT=development, start reload server otherwise start gunicorn server
  • read PADDLES_URL from env variable instead of src/config.py

@VallariAg VallariAg self-assigned this Sep 12, 2023
@VallariAg VallariAg requested a review from kamoltat September 12, 2023 07:22
@VallariAg VallariAg added documentation Improvements or additions to documentation enhancement Improving existing feature or logic labels Sep 12, 2023
@VallariAg VallariAg mentioned this pull request Sep 12, 2023
- add start_container.sh
- if DEPLOYMENT=development, start reload server
  otherwise start gunicorn server
- use env variables to map host and port
- read PADDLES_URL from env variable instead
  of src/config.py

Signed-off-by: Vallari Agrawal <[email protected]>
Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamoltat kamoltat merged commit 9bf2adf into main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Improving existing feature or logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants