refactor: update deps cid, multihash, and ipld #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
fix/cid-multihash-ipld
branch
2 times, most recently
from
08d33c5
to
e6105b1
Compare
The rust crate libipld is deprecated and ipld-core is the new _blessed_ ipld implementation in rust. This refactor updates our code to use this new dependency as well as up to date versions of the cid and multihash crates. There are no behavior changes in this PR.
nathanielc
force-pushed
the
fix/cid-multihash-ipld
branch
from
e6105b1
to
272974e
Compare
dav1do
approved these changes
Apr 30, 2024
store/src/sqlite/model.rs
Outdated
| /// Unified implementation of [`recon::Store`] and [`iroh_bitswap::Store`] that can expose the | ||
| /// individual blocks from the CAR files directly. | ||
| #[derive(Clone, Debug)] | ||
| pub struct ModelStore<H> |
There was a problem hiding this comment.
This file should be safe to delete.. I moved it to sql/event.rs and it looks like you applied to changes there.
nathanielc
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
nathanielc
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust crate libipld is deprecated and ipld-core is the new blessed ipld implementation in rust. This refactor updates our code to use this new dependency as well as up to date versions of the cid and multihash crates. There are no behavior changes in this PR.