Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quick logic fix #123

Merged
merged 3 commits into from
Sep 20, 2023
Merged

fix: quick logic fix #123

merged 3 commits into from
Sep 20, 2023

Conversation

solveit-rodion-kuhty
Copy link
Contributor

The goal of the pull request is not only to propose a working code as a solution to the requirement.
It is a tool for you to give context and explanation of your approach to the problem,
and transfer the knowledge to your team members.

Checklist (Mandatory):

  • I have a JIRA issue for this PR (link)
  • I have added a record to the CHANGELOG.md
  • I have tested new code locally
  • I have done a smoke test of the larger feature locally
  • I have merged the master (parent) branch into my feature branch and resolved all conflicts
  • I have added tests that prove my fix/implementation is effective or that my feature works

Checklist (Optional):

  • I have written the code according to the adopted style guide?

Additional notes

  • ...

mazhutoanton
mazhutoanton approved these changes Sep 20, 2023
View reviewed changes
packages/ui/src/components/Table/TableDataRow.tsx
@@ -60,7 +61,7 @@ const EmptySpace = styled.div({

const rankColors: RankProps['rankColor'][] = ['gold', 'silver', 'bronze'];

export const TableDataRow = ({ data, active, hasReward, shouldChangeStyle }: TableDataRowProps) => {
export const TableDataRow = ({ data, active, hasReward, shouldChangeStyle, activeAddress }: TableDataRowProps) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need new prop here activeAddress. Active adderess is in active prop

@mazhutoanton mazhutoanton merged commit 840211c into dev Sep 20, 2023
1 check failed
@mazhutoanton mazhutoanton deleted the fix/fix-release-logic branch September 20, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazhutoanton mazhutoanton mazhutoanton approved these changes

@skambalin skambalin Awaiting requested review from skambalin skambalin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solveit-rodion-kuhty @mazhutoanton