This repository has been archived by the owner on May 24, 2024. It is now read-only.
[Terra-Dev-Site] Reverts MDX version from V2 to V1 #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saket2403
approved these changes
Aug 22, 2023
sdadn
approved these changes
Aug 22, 2023
sycombs
approved these changes
Aug 22, 2023
BenBoersma
approved these changes
Aug 22, 2023
sdadn
added
terra-application-v1
terra-dev-site-v7
and removed
terra-application-v1
labels
8 tasks
added 2 commits
August 22, 2023 20:47
This was referenced Aug 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Terra-Dev-Site v7 has been updated to consume latest version of MDX packages to fix CVE's reported on older version.
https://github.com/cerner/terra-application/pull/320/files
Migration to MDX v2 requires changes on existing MDX files ( breaking changes ). Hence this change should be released with Major version of terra-dev-site to fix the CVE.
To resolve the issues caused by newer version of MDX packages. We need to revert changes made by PR 320 and update terra-application V1 branch to downgrade the Mdx versions to ^1.0.0
What was changed:
Reverted only MDX upgrades made on https://github.com/cerner/terra-application/pull/320/files
Why it was changed:
MDX2 has Breaking changes and will cause issue with existing MDX files. Since it is breaking the existing components we need to downgrade the versions back to ^1
Testing
There were few WDIO screenshots which were updated with incorrect changes as shown in below screenshot
Before Downgrading to MDX V1
After Downgrading to MDX V1
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9533
Thank you for contributing to Terra.
@cerner/terra