This repository has been archived by the owner on May 24, 2024. It is now read-only.
[Application-Base] Added prop to remove scroll from powerchart #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugan2416
approved these changes
Sep 8, 2023
supreethmr
reviewed
Sep 11, 2023
packages/terra-application/src/application-base/ApplicationBase.jsx
Outdated
Show resolved
Hide resolved
supreethmr
reviewed
Sep 11, 2023
| @@ -23,4 +23,8 @@ | |||
| width: 100%; | |||
| z-index: 1; | |||
| } | |||
|
|
|||
| .remove-scroll { | |||
| overflow: visible; | |||
There was a problem hiding this comment.
https://caniuse.com/?search=overflow%3A%20visible
overflow-visible is not supported on IE 10 and IE 11 have we tested this on the IE11 and IE10 browsers.
There was a problem hiding this comment.
Since this is an MPage-specific change and MPages 9.0 supports only edge. We do not have to worry about IE.
Co-authored-by: Supreeth <[email protected]>
supreethmr
approved these changes
Sep 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added prop to remove scroll from powerchart.
What was changed:
noScrollprop was added to remove the scroll by adding a custom style to terra-scroll.Why it was changed:
An additional scroll appeared in powerchart for viewpoint tab list control when it was wrapped with App base.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9568
Thank you for contributing to Terra.
@cerner/terra