This repository has been archived by the owner on May 24, 2024. It is now read-only.
Updated redwood theme's default density to 'comfortable' #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
approved these changes
Jan 23, 2024
sycombs
approved these changes
Jan 23, 2024
| @@ -122,12 +122,17 @@ const ApplicationBase = ({ | |||
|
|
|||
| const { localeOverride, themeOverride } = useTestOverrides(); // Allows us to test deployed applications in different locales. | |||
|
|
|||
| let density = themeDensity || themeConfig?.density; | |||
| if (!density && themeName === 'redwood-theme') { | |||
There was a problem hiding this comment.
Small suggestion: If we swap the conditions
Suggested change
| if (!density && themeName === 'redwood-theme') { | |
| if (themeName === 'redwood-theme' && !density) { |
then it will only check density when the theme is redwood since it will short-circuit and only the first condition needs to be evaluated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
The default density for redwood has been updated to 'comfortable'.
Why it was changed:
Consumers could forget the density option, this will ensure something still displays even if they forget it.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-XXXX
Thank you for contributing to Terra.
@cerner/terra