This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-application-navigation] Prevent error when using focus trap with react intl v5 #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhenkes
requested review from
emilyrohrbough,
ryanthemanuel,
StephenEsser and
tbiethman
as code owners
yuderekyu
reviewed
Mar 4, 2021
yuderekyu
approved these changes
Mar 4, 2021
5 tasks
benbcai
approved these changes
Mar 5, 2021
tbiethman
approved these changes
Mar 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Focus trap will throw a "cannot read property 'ownerDocument' of null" when the child component isn't an html element. See: focus-trap/focus-trap-react#44 (comment)
The drawer menu is wrapped in injectIntl. In our current version it is an html element, but in react intl v5 it nolonger is an html element.
I believe this could be fixed by upgrading focus trap, but the easiest safest fix is to wrap the drawer menu in a div... which is what I have done here.
Closes #
Deployment Link
https://terra-framework-deployed-pr-#.herokuapp.com/
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra