This repository has been archived by the owner on May 24, 2024. It is now read-only.
Update Bar unit tests to use Jest #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
reviewed
Jan 8, 2024
packages/carbon-graphs/tests/unit/controls/Bar/AxisInfoRow.test.js
Outdated
Show resolved
Hide resolved
adoroshk
reviewed
Jan 8, 2024
packages/carbon-graphs/tests/unit/controls/Bar/BarPanning.test.js
Outdated
Show resolved
Hide resolved
adoroshk
approved these changes
Jan 8, 2024
Co-authored-by: Alla Doroshkevych <[email protected]>
Co-authored-by: Alla Doroshkevych <[email protected]>
Co-authored-by: Alla Doroshkevych <[email protected]>
kenk2
reviewed
Jan 8, 2024
| @@ -87,7 +87,7 @@ describe('Bar - Panning', () => { | |||
|
|
|||
| expect(() => { graphDefault.reflow(panData); }).toThrowError(errors.THROW_MSG_INVALID_DATA); | |||
| }); | |||
| it('throws error when undefined value is passed as y', () => { | |||
| it('throws aan error when y is passed as undefined', () => { | |||
There was a problem hiding this comment.
I believe this got updated in: 6cf7494
| ]; | ||
|
|
||
| const plugins = [ | ||
| '@babel/plugin-proposal-object-rest-spread', |
There was a problem hiding this comment.
Maybe not in this PR but I believe this is the deprecated version of this plugin. If you're continuing work on this it might be a good idea to use @babel/plugin-transform-object-rest-spread like we're doing here with the other babel plugins.
There was a problem hiding this comment.
Thanks for pointing that out! I'll make that change in the next PR.
adoroshk
approved these changes
Jan 8, 2024
kenk2
approved these changes
Jan 8, 2024
This was referenced Jan 8, 2024
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the repo to utilize Jest for unit tests instead of Karma. Since there are a large amount of tests to go over, this PR narrows the scope to only the Bar graph. Other graph types and unit tests will be updated in subsequent PRs.
Note: A small subset of tests are failing due to differing values or due to an undefined value in the graph API. These tests are being skipped for now as they require dedicated debugging and the current objective is to switch over to Jest for unit tests. These failing tests will be fixed in a separate Jira.
Testing
This change was tested using:
The CICD was switched over to utilize Jest and it is currently passing:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9813
Thank you for contributing to Terra.
@cerner/terra