Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataplane parser failing to parse AS names with pipe characters #2488

Merged

Conversation

DigitalTrustCenter
Copy link
Contributor

At the time of writing, the sshpwauth.txt feed contains an AS name with a pipe character ('|').
AS262907 - BRASIL TECPAR | AMIGO | AVATO

The existing dataplane parser throws an error on that line, as it splits the data fields on just the pipe character.
From the feed header: "Each field is separated by a pipe symbol ('|') and at least two whitespace characters on either side."
Technically there are way more characters other that space that are whitespace characters, but just space seems to be used.
Hence we can split on ' | ' instead to fix this line breaking.

@sebix sebix merged commit 4eb0f7a into certtools:develop Apr 4, 2024
18 of 20 checks passed
sebix added a commit that referenced this pull request Apr 4, 2024
sebix added a commit that referenced this pull request Apr 4, 2024
@sebix
Copy link
Member

sebix commented Apr 4, 2024

Thank you for the excellent PR, including the test case :)

@sebix sebix added this to the 3.3.1 milestone Apr 4, 2024
@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: bots labels Apr 4, 2024
@sebix sebix self-assigned this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants