Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowserver: Fix parameter 'reports' behaviour if empty string #2523

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

sebix
Copy link
Member

@sebix sebix commented Aug 16, 2024

if the parameter reports is an empty string (or only contains whitespace), behave as if the parameter is not set and select all reports

fixes #2521

it the parameter is an empty string (or only contains whitespace), behave as if the parameter is not set and select all reports

fixes certtools#2521
@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: bots labels Aug 16, 2024
@sebix sebix added this to the 3.3.1 milestone Aug 16, 2024
@sebix sebix requested a review from aaronkaplan August 16, 2024 14:47
@sebix sebix mentioned this pull request Aug 27, 2024
Copy link
Member

@aaronkaplan aaronkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@sebix sebix merged commit 51077a5 into certtools:develop Sep 3, 2024
20 checks passed
@sebix sebix deleted the fix-2521 branch September 3, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shadowserver documentation: if reports is "", things don't work
2 participants