Skip to content

Commit

Permalink
CI: Always run the build job, never cancel it (fastly#868)
Browse files Browse the repository at this point in the history
  • Loading branch information
JakeChampion authored Jul 31, 2024
1 parent a3944d7 commit 1820b0b
Showing 1 changed file with 32 additions and 5 deletions.
37 changes: 32 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
name: CI
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}
cancel-in-progress: true
on:
pull_request:
push:
Expand All @@ -17,6 +14,9 @@ env:
jobs:

check-changelog:
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}-check-changelog
cancel-in-progress: true
if: github.ref != 'refs/heads/main'
runs-on: ubuntu-latest
steps:
Expand All @@ -28,6 +28,9 @@ jobs:
- run: npm run format-changelog

check-docusaurus:
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}-check-docusaurus
cancel-in-progress: true
if: github.ref != 'refs/heads/main'
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -162,6 +165,9 @@ jobs:
if: steps.cache-crate.outputs.cache-hit != 'true'

run_wpt:
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}-run_wpt-${{matrix.profile}}
cancel-in-progress: true
if: github.ref != 'refs/heads/main'
name: Run Web Platform Tests
strategy:
Expand Down Expand Up @@ -223,6 +229,9 @@ jobs:
# Consumes all published artifacts from all the previous build steps, and runs
# the integration tests for the linux build.
sdktest:
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}-sdktest-${{matrix.profile}}
cancel-in-progress: true
if: github.ref != 'refs/heads/main'
runs-on: ubuntu-latest
needs: [build, ensure_cargo_installs]
Expand Down Expand Up @@ -279,6 +288,9 @@ jobs:


shellcheck:
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}-shellcheck
cancel-in-progress: true
env:
SHELLCHECK_VERSION: v0.8.0
runs-on: ubuntu-latest
Expand Down Expand Up @@ -310,6 +322,9 @@ jobs:
run: ci/shellcheck.sh

format:
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}-format
cancel-in-progress: true
if: github.ref != 'refs/heads/main'
runs-on: ubuntu-latest
steps:
Expand All @@ -329,6 +344,9 @@ jobs:
ci/rustfmt.sh
test-npm-package:
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}-test-npm-package-${{matrix.node-version}}
cancel-in-progress: true
if: github.ref != 'refs/heads/main'
runs-on: ubuntu-latest
needs: [build, starlingmonkey-build]
Expand All @@ -354,6 +372,9 @@ jobs:
- run: npm test

e2e:
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}-e2e
cancel-in-progress: true
if: github.ref != 'refs/heads/main'
runs-on: ubuntu-latest
needs: [build]
Expand Down Expand Up @@ -394,8 +415,11 @@ jobs:
path: starling.wasm

starlingmonkey-run_wpt:
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}-starlingmonkey-run_wpt
cancel-in-progress: true
if: github.ref != 'refs/heads/main'
name: Run Web Platform Tests
name: Run Web Platform Tests (starlingmonkey)
needs: [starlingmonkey-build, ensure_cargo_installs]
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -447,6 +471,9 @@ jobs:
run: node ./tests/wpt-harness/run-wpt.mjs --starlingmonkey -vv

starlingmonkey-sdktest:
concurrency:
group: ${{ github.head_ref }}-${{ github.workflow}}-starlingmonkey-sdktest-${{matrix.profile}}-${{matrix.platform}}
cancel-in-progress: true
if: github.ref != 'refs/heads/main'
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -504,4 +531,4 @@ jobs:

- run: SUFFIX_STRING=${{matrix.profile}} node integration-tests/js-compute/test.js ${{ matrix.platform == 'viceroy' && '--local' || '' }}
env:
FASTLY_API_TOKEN: ${{ secrets.FASTLY_API_TOKEN }}
FASTLY_API_TOKEN: ${{ secrets.FASTLY_API_TOKEN }}

0 comments on commit 1820b0b

Please sign in to comment.