Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-10347: Added Debian 12 x86_64 AMI to cf-remote #67

Merged
merged 2 commits into from
Nov 6, 2023
Merged

ENT-10347: Added Debian 12 x86_64 AMI to cf-remote #67

merged 2 commits into from
Nov 6, 2023

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Oct 26, 2023 •
edited
Loading 

larsewi@zyra:cf-remote % cf-remote spawn --platform debian-12-x64 --count 1 --role hub --name test
---snip---
larsewi@zyra:cf-remote % cf-remote show
@test: (1 host in eu-west-1, aws)
  [email protected]
    hub, latest-debian-12-x64hub0, debian-12-x64, m3.xlarge, 172.31.25.167, 
    54.72.6.161, 59d02ac536cea38915173a2295601f9d4b8107ba, larsewi-ed25519, 
    cfengine-test


Total: 1 host in 1 group
larsewi@zyra:cf-remote % ssh [email protected]
---snip---
admin@ip-172-31-25-167:~$ cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
admin@ip-172-31-25-167:~$ 
logout
Connection to 54.72.6.161 closed.

@larsewi
Add .DS_Store to .gitignore
c60aaa9 
The file .DS_Store stores custom attributes in folders on macOS. It can
be quite annoying when it gets staged after `git add .`, thus I'll add
it to .gitignore.

Ticket: None
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi larsewi marked this pull request as draft October 26, 2023 11:05
@larsewi larsewi changed the title ENT-10347: Added Debian 12 x86_64 AMI to cf-remote WIP: ENT-10347: Added Debian 12 x86_64 AMI to cf-remote Oct 26, 2023
@larsewi
Added Debian 12 x86_64 AMI to cf-remote
9e30871 
Ticket: ENT-10347
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi larsewi marked this pull request as ready for review October 26, 2023 11:15
@larsewi larsewi changed the title WIP: ENT-10347: Added Debian 12 x86_64 AMI to cf-remote ENT-10347: Added Debian 12 x86_64 AMI to cf-remote Oct 26, 2023
nickanderson
nickanderson approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is how we do it, but it sort of seems like we should perhaps be using system manager "public identifiers" so that the region doesn't matter?

https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/finding-an-ami.html

Find the latest Amazon Linux AMI using Systems Manager

Amazon EC2 provides AWS Systems Manager public parameters for public AMIs maintained by AWS that you can use when launching instances. For example, the EC2-provided parameter /aws/service/ami-amazon-linux-latest/amzn2-ami-hvm-x86_64-gp2 is available in all Regions and always points to the latest version of the Amazon Linux 2 AMI in a given Region.
To find the latest Amazon Linux 2023 AMI using AWS Systems Manager, see Get started with Amazon Linux 2023.
The Amazon EC2 AMI public parameters are available from the following path:
/aws/service/ami-amazon-linux-latest
You can view a list of all Linux AMIs in the current AWS Region by running the following AWS CLI command.
aws ssm get-parameters-by-path --path /aws/service/ami-amazon-linux-latest --query "Parameters[].Name"

@larsewi
Copy link
Contributor Author

larsewi commented Oct 27, 2023 •
edited by jira bot
Loading

I see this is how we do it, but it sort of seems like we should perhaps be using system manager "public identifiers" so that the region doesn't matter?

Yes @nickanderson that would be very cool 🚀 Created ticket CFE-4275

@olehermanse olehermanse merged commit 9467ee1 into cfengine:master Nov 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickanderson nickanderson nickanderson approved these changes

@olehermanse olehermanse olehermanse approved these changes

@craigcomstock craigcomstock Awaiting requested review from craigcomstock

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larsewi @nickanderson @olehermanse