-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENT-11202, ENT-11335, ENT-11305: TOC bug-fixes #3220
Conversation
Ticket: ENT-11202 ENT-11335 ENT-11305 Changelog: None Signed-off-by: Mikita Pilinka <[email protected]>
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/527/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-527/output/_site/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the preview, seems to work well
@mineralsfree remember to bring this to 3.21 and Alvaldi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me but it seems like this could be split up into a few comments with explanations of what problem they fixed and how?
@craigcomstock we discussed this in person; a bit hard to untangle, some of the changes probably won't work separately (and so it doesn't make so much sense to split into separate commits). We considered to merge all the tickets into one ticket, but I said it was okay to do it like this. Also, keeping it together will probably make it quite a bit easier when cherry-picking. The commit message could use a bit more words though, for example a list of what issues were fixed, instead of relying only on the tickets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Cherry-picked in #3227 |
I've updated the PR description. Will make better commit messages next time |
Improvements:
Ticket: ENT-11202 ENT-11335 ENT-11305
Changelog: None
Signed-off-by: Mikita Pilinka [email protected]