Updated Advanced Search Tips #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flacoman91
changed the title
| <div className="tips"> | ||
| <div className="tip"> | ||
| <h4>And/Or</h4> | ||
| <div className="o-expandable_content"> |
There was a problem hiding this comment.
The structure here looks like it's:
o-expandable
o-expandable_content
o-expandable_content
o-expandable_content
Expandables were built with the idea it would be one content area per expandable, so it is expecting this structure:
o-expandable
o-expandable_content
o-expandable
o-expandable_content
o-expandable
o-expandable_content
Additionally, it would expect to have a o-expandable_target for toggling the expandable (see https://cfpb.github.io/design-system/components/expandables). Are these used for some expandable styles, but are not actually expandables?
There was a problem hiding this comment.
Yeah, basically are used for the styling that comes with design system.
There was a problem hiding this comment.
Could you give this another look? I'm necromancing this PR from a couple years ago.
…rch-tipsupdate # Conflicts: # src/components/iconMap.js
flacoman91
requested review from
anselmbradford and
wwhorton
and removed request for
KatherynRizek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address GHE 1564 / CABL-230 - CCDB18
Advanced Search tips
Adding more examples to match word doc requirement
Adding mouseover tooltip
Copied tooltip css from bootstrap so we don't accidentally import other styles from bootstrap
Added footer with link to ElasticSearch
Screenshot:
