Prevent tile map from overlapping legend on small screens #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -475,7 +475,7 @@ class TileMap { | |||
|
|
|||
| options.chart.marginRight = 0; | |||
| options.chart.marginLeft = 0; | |||
| options.chart.marginTop = legendHeight; | |||
| options.chart.marginTop = legendHeight + 15; | |||
There was a problem hiding this comment.
Should this be set here instead?
There was a problem hiding this comment.
I assumed legendHeight was used to control the height of the legend but it looks like the value is only used to set a buffer between the map and the legend. So I think you're right, it probably makes more sense to alter the breakpoints array. 👍
There was a problem hiding this comment.
I ended up just increasing the margin at all the breakpoints because IMHO the map is too close to the legend at most sizes.
Increase tile map's top margin to prevent it from overlapping the legend.
BrewCityBoy
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a small margin to prevent the tile map from overlapping the legend on small screens (~750px).
Fixes DATAP-30.
Screenshots
Checklist