-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAP-1208 Convert reducers to RTK slices #482
Draft
wwhorton
wants to merge
120
commits into
main
Choose a base branch
from
WW-DATAP-1208-reducers-use-slices
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/cfpb/ccdb5-ui into WW-DATAP-1208-reducers-use-slices
# Conflicts: # src/actions/filter.js # src/actions/view.js # src/components/Filters/FilterPanel.js # src/components/Filters/FilterPanel.spec.js # src/components/Filters/FilterPanelToggle.js # src/components/List/ListPanel/ListPanel.js # src/components/Map/MapPanel.js # src/components/Trends/ExternalTooltip/ExternalTooltip.js # src/components/Trends/ExternalTooltip/ExternalTooltip.spec.js # src/components/Trends/ExternalTooltip/TooltipRow.js # src/components/Trends/TrendsPanel.js # src/components/Warnings/Warning.spec.js # src/reducers/trends/selectors.js
…-1208-reducers-use-slices
# Conflicts: # package.json # src/components/Filters/CompanyReceivedFilter.js # src/components/Filters/DateFilter.js # src/components/Filters/__tests__/__snapshots__/CompanyReceivedFilter.spec.js.snap
flacoman91
reviewed
Jul 30, 2024
import { defaultAggs } from '../../../reducers/aggs/aggs'; | ||
import { defaultQuery } from '../../../reducers/query/query'; | ||
import { aggsState } from '../../../reducers/aggs/aggsSlice'; | ||
import { queryState } from '../../../reducers/query/querySlice'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be updated to filterState / filtersSlice
…-1208-reducers-use-slices # Conflicts: # src/components/Filters/FilterPanel.js # src/components/Filters/SimpleFilter.js # src/components/Filters/__tests__/SimpleFilter.spec.js # src/reducers/view/view.js # src/utils/index.js
remove debug
flacoman91
force-pushed
the
WW-DATAP-1208-reducers-use-slices
branch
from
September 11, 2024 19:48
2964229
to
88c45ee
Compare
flacoman91
force-pushed
the
WW-DATAP-1208-reducers-use-slices
branch
from
September 19, 2024 22:06
207f85f
to
9ef8164
Compare
fixing some tests adding middleware, fixing tests update tests updating complaints fix unit test coverage fixing unit tests fix url spec fix complaint spec message spec update querymanager
flacoman91
force-pushed
the
WW-DATAP-1208-reducers-use-slices
branch
from
September 19, 2024 23:51
007f8a5
to
8f1945d
Compare
# Conflicts: # src/components/Filters/CompanyReceivedFilter.spec.js # src/components/TabbedNavigation.spec.js
…-1208-reducers-use-slices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux Toolkit divides redux state into "slices", which make managing state easier and more efficient. Explorer was converted to use slices, but CCDB hadn't yet. This is a PR converting all the reducers to slices, updating tests to accommodate the changes, and refactoring code where necessary, mainly in dispatches. Most of the content of the actions directory was removed since it's handled in the extraReducers piece of the slices, but where it seemed to make more sense to leave them as is, I did.
Removals
Changes
Testing
yarn test
: All tests should passNotes
Todos
Checklist