Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATAP-1218: Need a focus state for accessibility (#1858) #485

Merged
merged 2 commits into from
Jan 23, 2024
Merged

DATAP-1218: Need a focus state for accessibility (#1858) #485

merged 2 commits into from
Jan 23, 2024

Conversation

BrewCityBoy
Copy link
Contributor

@BrewCityBoy BrewCityBoy commented Jan 19, 2024 •
edited by contolini
Loading

This is a simple CSS update to add hover and focus states to the tabbed-navigation class/buttons.

Address: DATAP-1218 DATAP-1218

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@BrewCityBoy BrewCityBoy self-assigned this Jan 19, 2024
contolini
contolini approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only suggestion is to use the color variables instead of the hex code.

src/components/TabbedNavigation.less Outdated Show resolved Hide resolved
src/components/TabbedNavigation.less Outdated Show resolved Hide resolved
@BrewCityBoy BrewCityBoy added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 878056d Jan 23, 2024
2 checks passed
@BrewCityBoy BrewCityBoy deleted the joshua_tabbedNav-focus-hover-css branch January 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contolini contolini contolini approved these changes

@wwhorton wwhorton Awaiting requested review from wwhorton

Assignees

@BrewCityBoy BrewCityBoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrewCityBoy @contolini