DATAP-1510 Conversion of AggregationBranch from Class to Functional Component #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 15, 2024 17:37
…d associated snapshots
…nce/absence of children (can be closed by default). Also removed old snapshot.
# Conflicts: # src/components/Filters/CollapsibleFilter/CollapsibleFilter.js # src/components/Filters/CollapsibleFilter/CollapsibleFilter.spec.js # src/components/Filters/Product.js
flacoman91
reviewed
Aug 22, 2024
src/components/Filters/Aggregation/AggregationBranch/AggregationBranch.js
Outdated
Show resolved
Hide resolved
flacoman91
reviewed
Aug 22, 2024
| desc, | ||
| children, | ||
| }) => { | ||
| const [isOpen, setOpen] = useState(hasChildren); |
There was a problem hiding this comment.
I thought we got rid of hasChildren, and it should just by default be:
const [isOpen, setOpen] = useState(true);
There was a problem hiding this comment.
We did, but it likely made its way back in due to a merge conflict on my end. I've taken these references out again.
flacoman91
reviewed
Aug 22, 2024
src/components/Filters/Aggregation/AggregationItem/AggregationItem.spec.js
Outdated
Show resolved
Hide resolved
flacoman91
reviewed
Aug 22, 2024
src/components/Filters/Aggregation/AggregationBranch/AggregationBranch.js
Outdated
Show resolved
Hide resolved
flacoman91
reviewed
Aug 22, 2024
Comment on lines
43
to
45
| title: PropTypes.string, | ||
| desc: PropTypes.string, | ||
| children: PropTypes.node, |
There was a problem hiding this comment.
These changes should be reverted.
flacoman91
reviewed
Aug 22, 2024
| expect(buttonAfter).toBeInTheDocument(); | ||
| expect(screen.getByText(props.desc)).toBeInTheDocument(); |
There was a problem hiding this comment.
Same with the changes in this file
flacoman91
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AggregationBranch conversion to functional component, along with associated unit tests
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist