Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1549 - hide tour when site loading #548

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

flacoman91
Copy link
Contributor

This disables/hides the "Take a tour" button when the site is loading the aggregations or trends, map, or list view.
Previously users were able to click the tour button when the site is loading, and this could cause problems
Remove useless / duplicate isLoading property in reducers since activeCall is enough to determine if the api is loading.

Screenshot before:
Screenshot 2024-09-27 at 1 49 00 PM

Screenshot after (no button):
Screenshot 2024-09-27 at 1 50 19 PM

@cdmh219 cdmh219 added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit d898d06 Sep 30, 2024
2 checks passed
@cdmh219 cdmh219 deleted the DATAP-1549-hide-tour-whenloading branch September 30, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants