Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paying for College: Grad Path - Fast Follows #8600

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Paying for College: Grad Path - Fast Follows #8600

merged 2 commits into from
Oct 3, 2024

Conversation

mistergone
Copy link
Member

This PR makes two "fast follow" fixes to the Grad Path application:

  • Move Grad PLUS loan on customize page
  • Modify Edit/Close cues on customize page

Changes

  • Changes the content of expandable cues
  • Moves the Grad PLUS content
  • Fixes a minor bug with undergrad/graduate content visibility

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

@mistergone
- Move Grad PLUS loan on customize page
5e39dbb 
- Modify Edit/Close cues on customize page
@mistergone mistergone requested a review from wpears October 3, 2024 13:51
@mistergone mistergone self-assigned this Oct 3, 2024
wpears
wpears requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interest tooltip isn't included for the grad PLUS loans, I added it as a suggestion above

.../paying_for_college/jinja2/paying-for-college/college-cost-blocks/05-customize-estimate.html Outdated Show resolved Hide resolved
@mistergone @wpears
Update cfgov/paying_for_college/jinja2/paying-for-college/college-cos…
20ee186 
…t-blocks/05-customize-estimate.html

Co-authored-by: Wyatt Pearsall <[email protected]>
@mistergone mistergone added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 02c4795 Oct 3, 2024
17 checks passed
@mistergone mistergone deleted the grad-ff branch October 3, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpears wpears wpears approved these changes

Assignees

@mistergone mistergone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistergone @wpears