-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: [Table] Pagination input label's 'for' property needs to align w…
…ith the input id (#356) Accessibility improvement ## Changes - [Table] Propagate Table id to Pagination component - [Pagination] Utilize `tableId` to uniquely identify and label Pagination's input element ## How to test this PR 1. Load paginated table in an application (couldn't get ANDI to recognize the error in Storybook) 2. Run [ANDI](https://www.ssa.gov/accessibility/andi/help/install.html) accessibility tool 3. Verify that it doesn't identify the following error - `Element nested in <label> but label[for=m-pagination_current-page] does not match element [id=m-pagination_current-page-default` ## Screenshots |ANDI Before|ANDI After| |---|---| |![Screenshot 2024-05-24 at 3 32 30 PM](https://github.com/cfpb/design-system-react/assets/2592907/cab51fd4-d9ae-467f-be96-78fcb006d434)|![Screenshot 2024-05-24 at 3 29 22 PM](https://github.com/cfpb/design-system-react/assets/2592907/ef31e63c-fa18-472f-ade8-8337965bcf4b)|
- Loading branch information
Showing
2 changed files
with
21 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters