Skip to content

Commit

Permalink
fix(Navbar): CFPB logo always takes you to consumerfinance.gov (#296)
Browse files Browse the repository at this point in the history
The CFPB logo should always navigate to consumerfinance.gov instead of a
generic / to allow for applications with their own routing that are
using the navbar, as per @natalia-fitzgerald's designs.

## Changes

- change `href` to be `https://www.consumerfinance.gov/`

## How to test this PR

1. Does clicking the CFPB logo in the NavBar take you to the CFPB home
page?

## Notes

- we could make the logo's `href` into a prop, but clicking this logo
across all CFPB properties should take you to `www.consumerfinance.gov`,
so it's better to hardcode it for consistency
  • Loading branch information
billhimmelsbach authored Jan 31, 2024
1 parent 4e947c7 commit edc2705
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/components/Navbar/Navbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ import './navbar.less';

export function CfpbLogo(): JSX.Element {
return (
<Link href='/' title='Home' aria-label='Home' className='o-header_logo'>
<Link
href='https://www.consumerfinance.gov/'
title='Home'
aria-label='Home'
className='o-header_logo'
>
<img className='o-header_logo-img' src={CFPBLogo} alt='CFPB Logo' />
</Link>
);
Expand Down

0 comments on commit edc2705

Please sign in to comment.