Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checkbox] Allows spread properties to reach the actual checkbox element #304

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Feb 2, 2024

closes #305

Use case

  • Properties used by zod and react-hook-form need be placed in the actual Checkbox (input element).

Changes

  • Allows spread properties to reach the actual checkbox element

How to Test

  • I believe just code inspection should be sufficient.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 3a2027d
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/65bd4653b3412e00083551d6
😎 Deploy Preview https://deploy-preview-304--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

meissadia
meissadia previously approved these changes Feb 2, 2024
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@shindigira shindigira merged commit df15462 into main Feb 2, 2024
7 of 9 checks passed
@shindigira shindigira deleted the checkbox-spread-properties-fix branch February 2, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Checkbox] Spread properties should be on the Checkbox (not container)
2 participants