Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert] Nest children in DIV instead of P to avoid invalid DOM structures #322

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[Alert] Nest children in DIV instead of P to avoid invalid DOM structures #322

merged 1 commit into from
Mar 28, 2024

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Mar 20, 2024 •
edited
Loading

Closes #321 #317

@netlify Netlify
Copy link

netlify bot commented Mar 20, 2024 •
edited
Loading

✅ Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 4f2e48a
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/65fb4ef8a728310008f4d12f
😎 Deploy Preview https://deploy-preview-322--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

billhimmelsbach
billhimmelsbach approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@meissadia meissadia merged commit 7e99e5d into main Mar 28, 2024
7 of 9 checks passed
@meissadia meissadia deleted the 321-alert-children-in-div branch March 28, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach billhimmelsbach approved these changes

@shindigira shindigira Awaiting requested review from shindigira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alert] Nest children in DIV instead of P
2 participants
@meissadia @billhimmelsbach