fix(skip-link): add focus ring #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
meissadia
approved these changes
Apr 2, 2024
billhimmelsbach
added a commit
to cfpb/sbl-frontend
that referenced
this pull request
Apr 2, 2024
Currently we don't have skip links that aid in making our content accessible to those using tab navigation. Closes: #359 ## Changes - adds skip link to App.tsx - adds missing `id="main"` to pages that still need it ## How to test this PR 1. Can you press `tab` then `enter` to skip to the main content of a page in the tab order? (Try pressing `tab` again to confirm. ## Screenshots <img width="533" alt="Screenshot 2024-04-02 at 3 35 55 AM" src="https://github.com/cfpb/sbl-frontend/assets/19983248/fb528a31-ad7e-4dc7-b941-dd9f8f786781"> ## Notes - the skip link could be a little fancier with its CSS transition like on cf.gov, but we're prioritizing [just the accessibility first](cfpb/design-system-react#330) - works in conjunction with cfpb/design-system-react#330 for the focus ring
billhimmelsbach
added a commit
to cfpb/sbl-frontend
that referenced
this pull request
Apr 2, 2024
**Note: same as #360, but now merging on main** Currently we don't have skip links that aid in making our content accessible to those using tab navigation. Closes: #359 ## Changes - adds skip link to App.tsx - adds missing `id="main"` to pages that still need it ## How to test this PR 1. Can you press `tab` then `enter` to skip to the main content of a page in the tab order? (Try pressing `tab` again to confirm. ## Screenshots <img width="533" alt="Screenshot 2024-04-02 at 3 35 55 AM" src="https://github.com/cfpb/sbl-frontend/assets/19983248/fb528a31-ad7e-4dc7-b941-dd9f8f786781"> ## Notes - the skip link could be a little fancier with its CSS transition like on cf.gov, but we're prioritizing [just the accessibility first](cfpb/design-system-react#330) - works in conjunction with cfpb/design-system-react#330 for the focus ring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very small change to add the focus ring in for skip links like it appears on consumerfinance.gov. There are other styles we could add from there potentially in the future, but the focus ring is the one that matter for accessibility, so I would like to prioritize this small change first.
Changes
How to test this PR
Screenshots
Before
After
Example from consumerfinance.gov
Notes