Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin underlying design-system deps to latest #336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pin underlying design-system deps to latest #336

wants to merge 1 commit into from

Conversation

wpears
Copy link
Member

@wpears wpears commented Apr 16, 2024

Currently, carat matching is used for the DS dep. Because of how the DS is using semver, this means it will always pull in the latest, when that might be breaking. Particularly, cfpb/design-system#1919 will need to be incorporated here to not cause breakages once that gets merged.

Another solution is to use semver more correctly in the DS, ie, put anything breaking behind a major version update. But for now, this PR is nice defense against changes there.

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for cfpb-design-system-react failed.

Name Link
🔨 Latest commit 22c1f88
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/661e85f99c7c790008a71638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants