Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): remove old ReactNode types #355

Merged
merged 1 commit into from
May 24, 2024

Conversation

billhimmelsbach
Copy link
Contributor

@billhimmelsbach billhimmelsbach commented May 24, 2024

The oldest components in the library appear to be using ReactNode instead of JSX.Element. This should fix some of the weird linting errors in repos that use the DSR

Changes

  • changes ReactNode to JSX.Element for paragraph and headings

How to test this PR

  1. Linting errors should go away when these components are used.

Screenshots

Screenshot 2024-05-24 at 8 50 50 AM

Copy link

netlify bot commented May 24, 2024

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit bde0e04
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/6650b76b3f789b0008d38090
😎 Deploy Preview https://deploy-preview-355--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@billhimmelsbach billhimmelsbach merged commit ddaa08e into main May 24, 2024
8 of 10 checks passed
@billhimmelsbach billhimmelsbach deleted the fix-types-on-p-and-heading branch May 24, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants