chore(Table): enabled ref forwarding #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shindigira
added a commit
to cfpb/sbl-frontend
that referenced
this pull request
May 28, 2024
…ow when overflowing (horizontal scrolling active) (#583) closes #547 Note: Requires cfpb/design-system-react#358 to be merged in first ## Changes - enhancement-style(tables): full borders will only show for overflowing - chore(tables): removed the need for `showTableBorders` ## How to test this PR 1. `yarn install` to get the latest DSR update with the table ref change 2. use [all-errors-warnings-no-syntax-errors.csv](https://github.com/cfpb/sbl-frontend/files/15444623/all-errors-warnings-no-syntax-errors.csv) or any register with multifield errors that causes overflowing/horizontal scrolling 3. Verify that tables without overflowing don't have full borders, tables that do have overflowing/horizontal scrolling have full borders ## Screenshot <img width="638" alt="Screenshot 2024-05-25 at 11 47 57 AM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/635e1840-4ef4-4e86-8fc9-679f62cc3903">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #359
Changes
divRefand atableRefHow to test
Reference
cfpb/sbl-frontend#547