Removed width: 100% from CFPB logo #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojbravo
requested review from
meissadia,
shindigira and
billhimmelsbach
as code owners
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shindigira
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Working!
To explain the issue further:
Chrome
If an asset (such as an image) doesn't have a parent's width set to a specific value, setting it's width to 100% has no affect -- and the asset will use it's natural size (i.e. if a logo is 70px then it's 70px inserted)
Safari
With 100% width, Safari will set an asset (image) to the maximum calculated of the parent while maintaining the aspect ratio.
Long-term solution to avoid this issue is to use an image container with a width of 100% and a set max-width.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for a "squished" CFPB logo on Safari