Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(footer): add target='_blank' -- for social links in the footer #376

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 43 additions & 16 deletions src/components/Footer/FooterCfGov.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,26 @@ export const FooterCfGov = ({
...properties
}: FootCfGovProperties & JSX.IntrinsicElements['footer']): JSX.Element => {
const navLinks = [
<a href={`${cfLink}/about-us/`} key='about'>
<a href={`${cfLink}/about-us/`} key='about' target='_blank'>
About Us
</a>,
<a href={`${cfLink}/about-us/contact-us/`} key='contact'>
<a href={`${cfLink}/about-us/contact-us/`} key='contact' target='_blank'>
Contact Us
</a>,
<a href={`${cfLink}/about-us/careers/`} key='careers'>
<a href={`${cfLink}/about-us/careers/`} key='careers' target='_blank'>
Careers
</a>,
<a href={`${cfLink}/about-us/events/`} key='events'>
<a href={`${cfLink}/about-us/events/`} key='events' target='_blank'>
Events
</a>,
<a
href={`${cfLink}/enforcement/information-industry-whistleblowers/`}
key='whistle'
target='_blank'
>
Industry Whistleblowers
</a>,
<a href={`${cfLink}/cfpb-ombudsman/`} key='ombudsman'>
<a href={`${cfLink}/cfpb-ombudsman/`} key='ombudsman' target='_blank'>
CFPB Ombudsman
</a>
];
Expand All @@ -47,6 +48,7 @@ export const FooterCfGov = ({
aria-label='Visit us on Facebook'
data-pretty-href={facebookLink}
href={facebookLink}
target='_blank'
>
<Icon name='facebook' isPresentational withBg />
</a>,
Expand All @@ -55,6 +57,7 @@ export const FooterCfGov = ({
aria-label='Visit us on Twitter'
data-pretty-href={twitterLink}
href={twitterLink}
target='_blank'
>
<Icon name='x' isPresentational withBg />
</a>,
Expand All @@ -63,6 +66,7 @@ export const FooterCfGov = ({
aria-label='Visit us on LinkedIn'
data-pretty-href={linkedinLink}
href={linkedinLink}
target='_blank'
>
<Icon name='linkedin' isPresentational withBg />
</a>,
Expand All @@ -71,6 +75,7 @@ export const FooterCfGov = ({
aria-label='Visit us on YouTube'
data-pretty-href={youtubeLink}
href={youtubeLink}
target='_blank'
>
<Icon name='youtube' alt='Visit us on YouTube' isPresentational withBg />
</a>,
Expand All @@ -79,67 +84,88 @@ export const FooterCfGov = ({
aria-label='Visit us on Flickr'
data-pretty-href={flickrLink}
href={flickrLink}
target='_blank'
>
<Icon name='flickr' alt='Visit us on Flickr' isPresentational withBg />
</a>
];

const linksCol1 = [
<a key='foia' href={`${cfLink}/foia-requests/`}>
<a key='foia' href={`${cfLink}/foia-requests/`} target='_blank'>
FOIA
</a>,
<a key='privacy' href={`${cfLink}/privacy/`}>
<a key='privacy' href={`${cfLink}/privacy/`} target='_blank'>
Privacy
</a>,
<a key='privacy-policy' href={`${cfLink}/privacy/website-privacy-policy/`}>
<a
key='privacy-policy'
href={`${cfLink}/privacy/website-privacy-policy/`}
target='_blank'
>
Website Privacy Policy &amp; Legal Notices
</a>,
<a key='data' href={`${cfLink}/data/`}>
<a key='data' href={`${cfLink}/data/`} target='_blank'>
Data
</a>,
<a key='open-government' href={`${cfLink}/open-government/`}>
<a
key='open-government'
href={`${cfLink}/open-government/`}
target='_blank'
>
Open Government
</a>,
<a
key='info-quality'
href={`${cfLink}/open-government/information-quality-guidelines/`}
target='_blank'
>
Information Quality Guidelines
</a>
];

const linksCol2 = [
<a key='dei' href={`${cfLink}/about-us/diversity-and-inclusion/`}>
<a
key='dei'
href={`${cfLink}/about-us/diversity-and-inclusion/`}
target='_blank'
>
Diversity &amp; Inclusion
</a>,
<a
key='adjudication'
href={`${cfLink}/administrative-adjudication-proceedings/`}
target='_blank'
>
Administrative Adjudication
</a>,
<a key='writing' href={`${cfLink}/plain-writing/`}>
<a key='writing' href={`${cfLink}/plain-writing/`} target='_blank'>
Plain Writing
</a>,
<a key='accessibility' href={`${cfLink}/accessibility/`}>
<a key='accessibility' href={`${cfLink}/accessibility/`} target='_blank'>
Accessibility
</a>,
<a key='civ-rights' href={`${cfLink}/office-civil-rights/`}>
<a key='civ-rights' href={`${cfLink}/office-civil-rights/`} target='_blank'>
Office of Civil Rights
</a>,
<a
key='no-fear'
href={`${cfLink}/office-civil-rights/no-fear-act-cummings-act/`}
target='_blank'
>
No FEAR Act &amp; Cummings Act
</a>,
<a key='tribal' href={`${cfLink}/tribal/`}>
<a key='tribal' href={`${cfLink}/tribal/`} target='_blank'>
Tribal
</a>
];

const linksCol3 = [
<a key='usa-gov' className='a-link a-link__icon' href='https://usa.gov/'>
<a
key='usa-gov'
className='a-link a-link__icon'
href='https://usa.gov/'
target='_blank'
>
<span className='a-link_text'>USA.gov</span>
<Icon
ariaLabel='External link'
Expand All @@ -151,6 +177,7 @@ export const FooterCfGov = ({
key='inspector'
className='a-link a-link__icon'
href='https://oig.federalreserve.gov/'
target='_blank'
>
<span className='a-link_text'>Office of Inspector General</span>
<Icon
Expand Down