Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Page] Filing landing #94

Closed
wants to merge 19 commits into from
Closed

[Page] Filing landing #94

wants to merge 19 commits into from

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Jun 27, 2023

Preview

Filing landing page

Changes

  • Incorporates latest text content from the Figma mockup
  • Integrates latest components
  • Identifies adjustments needed for Well component

Screenshots

Screen Shot 2023-06-27 at 2 11 52 PM

Questions/Notes

  • CFPB DS sets font-size of the <body> element to 20px but mockups seem to be based on 16px. Need to confirm this down-scaling is intended. Apologies, this was due to a browser setting on my machine and has been corrected 😵‍💫
  • Links with dotted bottom border: in the CFPB DS, this style is reserved for list links. Do we want to support this style for any link?
  • Navbar text size: Component declares it at 16px, mockups have it at 14px. Which is the desired size?

@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit ea4ac1c
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/649ca2a20f9edd0008c9f3bb
😎 Deploy Preview https://deploy-preview-94--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia force-pushed the page-login-landing branch 4 times, most recently from b551697 to e0fb6ac Compare June 28, 2023 20:15
@meissadia
Copy link
Contributor Author

We've moved to actually implementing this in the sbl-frontend app, so no longer needed here.

@meissadia meissadia closed this Jul 31, 2023
@meissadia meissadia deleted the page-login-landing branch July 31, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant