-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tag] Update styles per approved redesign #1777
Conversation
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
f1da474
to
c604110
Compare
Here’s what I’m seeing (mobile): |
Focus styles updated to show teal-20 background:
I opened #1778 for those issues. Since these inconsistencies are pre-existing in the DS pages, and are not related to the Tag styles, I don't think we should try to address them here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Closes #1760
Changes
(1) Correct Select page route in browser tests
(2) Styles for
.o-multiselect_choices
to match updated specsDefault
Hover
Focused
Active
Testing
Screenshots
Checklist
Testing checklist
Browsers
Accessibility
Other