Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tag] Update styles per approved redesign #1777

Merged
merged 4 commits into from
Oct 13, 2023
Merged

[Tag] Update styles per approved redesign #1777

merged 4 commits into from
Oct 13, 2023

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Oct 10, 2023

Closes #1760

Changes

(1) Correct Select page route in browser tests

(2) Styles for .o-multiselect_choices to match updated specs

Default

Hover

Focused

Active

Testing

  1. Visual inspection
  2. Automated tests
    • Browsers tests indicate a failure in MS Edge on Windows 10. I've manually tested in MS Edge (I can't figure out what Windows version I'm remotely connected to) and the Select works as expected.

Screenshots

State UI
Default default
Focus Screenshot 2023-10-12 at 10 29 27 AM
Hover hover
Hover/Focus hover:focus
Active active

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the CFPB development guidelines
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Browsers

  • Chrome on desktop
  • Firefox
  • Safari on macOS
  • Edge
  • Safari on iOS
  • Chrome on Android

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@netlify
Copy link

netlify bot commented Oct 10, 2023

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit a31cacd
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/65281f6bdab5700008efafa2
😎 Deploy Preview https://deploy-preview-1777--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia marked this pull request as ready for review October 10, 2023 22:42
@natalia-fitzgerald
Copy link
Contributor

@meissadia

  • I am seeing an odd thing when I view using the deploy link. There is a rounded corner on the text input field and the left corners of the multiselect. The single select does not have the rounded corners. When I view these Design System components outside of the deploy preview the corners for the text input and multiselect are not rounded. The text input and selscts should not have rounded corners.

Here’s what I’m seeing (mobile):

Chrome and Safari
IMG_9200

Safari
See left corners of multiselect
IMG_9201

@meissadia
Copy link
Contributor Author

@natalia-fitzgerald

Focus styles updated to show teal-20 background:
Screenshot 2023-10-12 at 10 29 27 AM

  • I am seeing an odd thing when I view using the deploy link.

I opened #1778 for those issues.

Since these inconsistencies are pre-existing in the DS pages, and are not related to the Tag styles, I don't think we should try to address them here.

@anselmbradford anselmbradford added the lerna-changelog/enhancement lerna label. DO NOT MODIFY label Oct 13, 2023
Copy link
Contributor

@natalia-fitzgerald natalia-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/enhancement lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement approved tag (pill) styling change
3 participants