Skip to content

Commit

Permalink
add bucket env var
Browse files Browse the repository at this point in the history
  • Loading branch information
cooldragontattoo committed Nov 19, 2024
1 parent 2272679 commit b39fc78
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/friendly-umbrella-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,4 @@ jobs:
--set image.tag=$GITHUB_SHA
--set mapping.host=${{ secrets.HOST }}
--set serviceAccount.name=${{ secrets.K8S_SERVICE_ACCOUNT }}
--set config.bucket=${{ secrets.BUCKET_NAME }}
--set config.AWS_STORAGE_BUCKET_NAME=${{ secrets.BUCKET_NAME }}
4 changes: 3 additions & 1 deletion friendly_umbrella/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,9 @@
if os.getenv("AWS_WEB_IDENTITY_TOKEN_FILE"):

DEFAULT_FILE_STORAGE = "storages.backends.s3boto3.S3Boto3Storage"
AWS_STORAGE_BUCKET_NAME = os.getenv("AWS_STORAGE_BUCKET_NAME")


# Allow setting AWS_S3_ENDPOINT_URL to enable testing against a local S3
if os.getenv("AWS_S3_ENDPOINT_URL") is not None:
AWS_S3_ENDPOINT_URL = os.getenv("AWS_S3_ENDPOINT_URL")
AWS_S3_ENDPOINT_URL = os.getenv("AWS_S3_ENDPOINT_URL")
2 changes: 1 addition & 1 deletion helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ serviceAccount:
name: service-account-name

config:
bucket: bucket_name
AWS_STORAGE_BUCKET_NAME: bucket_name

mapping:
enabled: true
Expand Down

0 comments on commit b39fc78

Please sign in to comment.