Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deployment GitHub Action, Helm Chart Modifications, and S3 Connections #6

Merged
merged 22 commits into from
Nov 25, 2024

Conversation

cooldragontattoo
Copy link
Contributor

@cooldragontattoo cooldragontattoo commented Nov 24, 2024

The PR is the result of our in-person work session--which is why its scope is much bigger than it should be.

Additions

  • Adds a GitHub Action that deploys the Friendly Umbrella app to EKS

    • Builds the Friendly-Umbrella image and scans it with twist lock.
  • Adds helm templates for mapping and config maps.

  • Connects friendly-umbrella to S3

Screenshots

Notes

  • Sorry this commit is so HUGE!

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Browsers

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer 8, 9, 10, and 11
  • Edge
  • iOS Safari
  • Chrome for Android

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@cooldragontattoo cooldragontattoo changed the title Add gha Add Deployment GitHub Action, Helm Chart Modifications, and S3 Connections Nov 24, 2024
Copy link
Member

@chosak chosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. I've rebased this. Let's continue to iterate.

@chosak chosak merged commit 6fdf0da into main Nov 25, 2024
1 check passed
@chosak chosak deleted the add-gha branch November 25, 2024 20:55
@chosak chosak mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants