Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Remove hash checking #152

Merged
merged 14 commits into from
Dec 18, 2015
Merged

Remove hash checking #152

merged 14 commits into from
Dec 18, 2015

Conversation

wpears
Copy link
Member

@wpears wpears commented Dec 17, 2015

Removes hash checking and morphs it into a schema check. Mostly leans on existing tests and the fieldFilter module (if the schema check fails, it returns an error from within pumped pipeline which destroys all streams in the pipeline and reports the error)

@hkeeler
Copy link
Member

hkeeler commented Dec 17, 2015

Looks like Travis itself blew up while running the tests in Docker:

Broadcast message from root@testing-gce-61e31d8a-051e-46fb-807b-94d57736bef9
    (unknown) at 16:45 ...

The system is going down for power off NOW!
The command "docker run --rm -e "AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID" -e "AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY" hmda/loader npm test -- -h $(echo "$ES_HOST")" exited with 143.

@wpears, did you see anything like this in your previous Travis/Docker wranglings?

I'm kicking the build back off now...

@hkeeler
Copy link
Member

hkeeler commented Dec 17, 2015

...and then it stalled out here: https://travis-ci.org/cfpb/grasshopper-loader#L870. Kicking it off again.

@hkeeler
Copy link
Member

hkeeler commented Dec 17, 2015

I think we're stepping on each others toes. I'll step away...

@wpears
Copy link
Member Author

wpears commented Dec 17, 2015

Yeah I'm really at a loss here, been working on this for a couple hours.

It works locally, it works locally in Docker... and it fails in Travis--using Docker.

So if it works locally with Docker but not on Travis with Docker... is that a bug in Travis's implementation of Dockerized builds?

@hkeeler
Copy link
Member

hkeeler commented Dec 18, 2015

Looks good. Created #155 so we don't forget about the tests that got commented out to make Travis happy.

hkeeler added a commit that referenced this pull request Dec 18, 2015
@hkeeler hkeeler merged commit dc557d6 into master Dec 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants