Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Profile] - Initial User Profile Form - Validation Fail State #32

Merged
merged 12 commits into from
Sep 6, 2023

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Aug 22, 2023

Closes #29

Changes

  • [chore] added error and disabled color class in the tailwind config
  • [chore] added the correct error icon
  • [feat] Added additional notice regarding LEI to the User Profile form
  • [feat] Added Step1FormErrorHeader component
  • [feat] Include links in the Error Header that smooth scroll to the field.
  • [chore] Utilized the figma's validation error messages meant for the user

Completed Screenshot (08/25/2023)

Screen Shot 2023-08-25 at 2 10 31 AM

@shindigira shindigira added the UI Tasks involving visual elements label Aug 22, 2023
@shindigira shindigira changed the title 29 input error validation styling User Profile - Initial User Profile Form - Validation Fail State Aug 22, 2023
@shindigira shindigira changed the title User Profile - Initial User Profile Form - Validation Fail State [User Profile] - Initial User Profile Form - Validation Fail State Aug 23, 2023
* feat: American Flag favicon

* chore: deleted unused vite icons
@natalia-fitzgerald
Copy link

natalia-fitzgerald commented Aug 24, 2023

@shindigira
Do you have access to the Figma file yet? Can we review which parts of the page are pulling in DSR components? I want to make sure to review those in this page context to be sure that they are functioning as expected. Almost everything (if not everything) on this page should be a reusable component.

  • The error text should be black not red
  • The well border should be gray (pull exact Gray from Figma file) (it looks black in your image)
  • The space under the H1 should be 30px
  • The blue link outline looks like it has a heavier dot at the beginning. Is this just an artifact of the screenshot?

Incomplete form submission

@shindigira
Copy link
Contributor Author

shindigira commented Aug 25, 2023

@natalia-fitzgerald Addressed all issues except the last one (regarding the link). See the latest screenshot in the starting post.

Also, will find the bandwidth to create the 3-part text introduction components in design-stories.

Changes:
- [fix] fixed accessibility in links that are in the 'Step1FormErrorHeader'
- [style] CFPB styling additions
@shindigira shindigira force-pushed the 29-input-error-validation-styling branch from b12050f to f3541e3 Compare August 25, 2023 06:25
@natalia-fitzgerald
Copy link

@shindigira
The space between the paragraph text and the notification or the well should be 45px. It looks like maybe 30px in your screenshot? At some point will I be able to review this in code?

@shindigira
Copy link
Contributor Author

@natalia-fitzgerald
Sure, we should find a time get the app working on your machine so you can see the frontend directly.

@shindigira shindigira merged commit 6fb046a into main Sep 6, 2023
1 of 2 checks passed
@meissadia meissadia deleted the 29-input-error-validation-styling branch September 22, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Tasks involving visual elements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Profile] - Initial User Profile Form - Validation Fail State - Draft
2 participants