Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(skip-links): add skip link and main id to missing pages #360

Merged
merged 2 commits into from
Apr 2, 2024
Merged

feat(skip-links): add skip link and main id to missing pages #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d711f00
feat(skip-links): add skip link and main id to missing pages
billhimmelsbach Apr 2, 2024
ec4cdb6
Merge branch '356-accessibility-improvements-main-icons-headings' int…
billhimmelsbach Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import classNames from 'classnames';
import { Link } from 'components/Link';
import { LoadingApp, LoadingContent } from 'components/Loading';
import ScrollToTop from 'components/ScrollToTop';
import { FooterCfGov, PageHeader } from 'design-system-react';
import { FooterCfGov, PageHeader, SkipNav } from 'design-system-react';
import 'design-system-react/style.css';
import Error500 from 'pages/Error/Error500';
import { NotFound404 } from 'pages/Error/NotFound404';
Expand Down Expand Up @@ -101,6 +101,7 @@ function BasicLayout(): ReactElement {

return (
<div className='h-dvh'>
<SkipNav />
<PageHeader links={headerLinks} />
<Outlet />
<FooterCfGov />
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Filing/FilingApp/FilingOverviewPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default function FilingOverview(): ReactElement {
Shared Landing
</Link>
</CrumbTrail>
<main id='main-content' className='my-10'>
<main id='main' className='my-10'>
<Heading type='1'>File your Small Business Lending data</Heading>
<Heading type='3'>
You may file official small business lending data for your
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Filing/PaperworkNotice.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import './Notices.less';

function PaperworkNotice(): ReactElement {
return (
<Layout.Main layout='2-1' bleedbar classes='notices'>
<Layout.Main id='main' layout='2-1' bleedbar classes='notices'>
<Layout.Wrapper>
<Layout.Content flushBottom>
<CrumbTrail>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Filing/PrivacyNotice.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import './Notices.less';

function PrivacyNotice(): ReactElement {
return (
<Layout.Main layout='2-1' bleedbar classes='notices'>
<Layout.Main id='main' layout='2-1' bleedbar classes='notices'>
<Layout.Wrapper>
<Layout.Content flushBottom>
<CrumbTrail>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Filing/UpdateFinancialProfile/UfpForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default function UFPForm({
const onClearform = (): void => reset();

return (
<main id='update-financial-profile'>
<main id='main'>
<CrumbTrail>
<Link isRouterLink href='/landing' key='home'>
Platform home
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Filing/ViewInstitutionProfile/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function InstitutionDetails(): JSX.Element | null {
});

return (
<main id='view-institution-profile'>
<main id='main'>
<CrumbTrail>
<Link href='/landing' key='home'>
Platform home
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Filing/ViewUserProfile/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export default function ViewUserProfile(): JSX.Element | null {
<Grid.Wrapper center>
<Grid.Row>
<Grid.Column width={8}>
<main id='main-content' className='mb-[2.813rem] mt-[1.875rem]'>
<main id='main' className='mb-[2.813rem] mt-[1.875rem]'>
<CrumbTrail>
<Link href='/landing' key='home'>
Platform home
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ProfileForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function CompleteUserProfileForm(): JSX.Element | null {
: Step1Form;

return (
<main>
<main id='main'>
<UserProfileForm />
</main>
);
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Summary/Summary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function Summary(): JSX.Element | null {
state.scenario === scenarios.SuccessInstitutionProfileUpdate;

return (
<main id='Summary'>
<main id='main'>
{isSuccessInstitutionProfileUpdate ? (
<CrumbTrail>
<Link isRouterLink href='/landing' key='home'>
Expand Down