[User Profile] - Layout View - Submitted User Profile - Success/Failure #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - [feat] Replaced the react-select dropdown indicator with the CFPB design system dropdown indicator - [chore] Moved zod types Step1Form to types.ts
…end into 41-react-select-dropdowns
…ox [Associated Financial Information]
shindigira
changed the title
meissadia
approved these changes
Sep 28, 2023
shindigira
changed the title
shindigira
changed the title
|
@shindigira |
Unfortunately, no live linking the sbl-frontend app; only DSR can be live linked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42
Closes #43
Closes #66
Closes #67
Changes
Implements the submitted User Profile page.
Added Changes
For the "Associated financial institutions" label (on User profile submission status page) can we make it singular when there is one financial institution and plural when there are two or more?"Associated financial institution(s)" to keep it consistentHow to Test
const [selectedScenario, setScenario] = useState<Scenarios>(Scenarios.Success1A);with the scenarios found in Step2FormHeader.data.tsx.Screenshot(s) - Updated (10/09/2023)
Scenario 2 - Error
Scenario 1B - Warning
Scenario 1C/3B - Warning
Scenario 2 - Success
Reference(s)
Scenarios 1A,1B,1C, 2 and 3B Descriptions