Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(Button): border update to match Secondary button dimensions #689

Merged
merged 8 commits into from
Jun 26, 2024
Merged

style(Button): border update to match Secondary button dimensions #689

merged 8 commits into from
Jun 26, 2024

Conversation

shindigira
Copy link
Contributor

closes #688

Changes

  • Use of a border and with a color matching each appearance's (primary/destructive/etc) background-color

billhimmelsbach
billhimmelsbach reviewed Jun 19, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd need Natalia's eyes on this one to approve. Maybe you can show her when she gets back? Here's my attempt at capturing it in screenshots:
before
after

@shindigira
Copy link
Contributor Author

shindigira commented Jun 20, 2024 •
edited
Loading

@natalia-fitzgerald Please check the sizes of the buttons in the screenshot and tell us if it is acceptable

@shindigira shindigira requested a review from ojbravo as a code owner June 24, 2024 23:52
@natalia-fitzgerald
Copy link

@shindigira
From what I can tell from the screenshots the after shows the primary and secondary buttons as the same height. This is correct.

This was referenced Jun 25, 2024
Closed
Closed
@shindigira shindigira enabled auto-merge (squash) June 26, 2024 01:13
@shindigira shindigira merged commit fc02120 into main Jun 26, 2024
3 checks passed
@shindigira shindigira deleted the 688-button-border-update branch June 26, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meissadia meissadia meissadia approved these changes

@ojbravo ojbravo Awaiting requested review from ojbravo

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Buttons] Border update
4 participants
@shindigira @natalia-fitzgerald @meissadia @billhimmelsbach