feat: ListLink - opens new tab by default, chore(footer & filing home): additional resources - clicking opens new tabs
#796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shindigira
requested review from
billhimmelsbach,
meissadia and
ojbravo
as code owners
shindigira
changed the title
There was a problem hiding this comment.
Heyo, just reiterating here what we talked about the 1:1 of instead of adding the blank target manually, incorporating Meissa's previous change into ListLinks here.
|
Heyo @shindigira! Did you want to take another crack at this one with the comment we discussed earlier from above? |
…ional-resources-new-tab-links
shindigira
changed the title
ListLink - opens new tab by default, chore(footer & filing home): additional resources - clicking opens new tabs
|
@billhimmelsbach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #795
Followup to #779, #784
Changes
ListLinksnow open new tabs by defaultHow to test this PR
Screenshots
References
#784
#779