Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Alert Updates #881

Merged
merged 18 commits into from
Sep 23, 2024
Merged

Error Alert Updates #881

merged 18 commits into from
Sep 23, 2024

Conversation

ojbravo
Copy link
Collaborator

@ojbravo ojbravo commented Aug 16, 2024

Closes #865

  • Updated content of Alerts on Resolve errors (syntax + logic) pages
  • Converted checkbox field level error to form level error on Warnings page
  • Added e2e tests for error Alerts

@billhimmelsbach
Copy link
Contributor

Let's get this in front of Natalia, I'll put it up on the dev environment.

@shindigira
Copy link
Contributor

@ojbravo @billhimmelsbach Since we are using a bottom error footer, do we want to keep the UX where the user is scrolled to the error header?

@billhimmelsbach
Copy link
Contributor

@ojbravo @billhimmelsbach Since we are using a bottom error footer, do we want to keep the UX where the user is scrolled to the error header?

@natalia-fitzgerald

@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented Sep 20, 2024

@ojbravo @billhimmelsbach Since we are using a bottom error footer, do we want to keep the UX where the user is scrolled to the error header?

I think the original behavior works for now with the scroll, but let's briefly ask Natalia at the next dev/design sync if we want to make improvements here in future tickets.

@ojbravo ojbravo marked this pull request as draft September 20, 2024 20:27
@ojbravo ojbravo marked this pull request as ready for review September 23, 2024 15:03
@ojbravo
Copy link
Collaborator Author

ojbravo commented Sep 23, 2024

Updated alert order: Screenshot 2024-09-23 at 9 18 35 AM

@shindigira shindigira self-requested a review September 23, 2024 15:31
Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! Excited to get this merged.

@ojbravo ojbravo merged commit 56e7bd3 into main Sep 23, 2024
4 checks passed
@ojbravo ojbravo deleted the 865-alerts branch September 23, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alerts] Update on Resolve Errors + Warnings pages
3 participants