Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] [Upload] Tests for syntax errors, logic errors and to verify a downloadable report #938

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Sep 18, 2024

closes #777
closes #802
closes #937
closes #958

Changes

  • Adds e2e test to check the navigation of when a user uploads a csv that produces syntax errors
  • Adds e2e test to check the navigation of when a user uploads a csv that produces logic errors
  • e2e: Verifies - a user can download a validation report after a syntax error has been upload
  • enhancement: Improves TypeScript handing in playwright.config.ts
  • feat: deletes individual reports in the e2e/pages/filing-app/uploadFile/downloads directory after the download report test finishes
  • chore: updated uploadFile.ts to be DRY
  • feat: Integrate uploadFile.ts with completeUploadLogicErrors.spec.ts
  • feat: Integrate uploadFile.ts with completeUploadSyntaxErrors.spec.ts
  • feat: Update unavailableApis.spec.ts with uploadFile.ts accordingly

How to Test

  • Run npx playwright test --ui
  • Run the completeSyntaxErrors.spec.ts test
  • Run the completeLogicErrors.spec.ts test
  • Run the unavailableApis.spec.ts test
  • Verify downloaded reports are being deleted from e2e/pages/filing-app/uploadFile/downloads

Screenshot

Screenshot 2024-09-20 at 2 15 50 PM

@shindigira shindigira changed the base branch from main to 777-all-syntax-errors-again September 18, 2024 19:35
@shindigira shindigira changed the title [e2e] Verify downloads reports after Syntax Errors upload [e2e] Verify downloads reports after a Syntax Errors upload Sep 18, 2024
@shindigira shindigira changed the title [e2e] Verify downloads reports after a Syntax Errors upload [e2e] Verify a downloaded report after a Syntax Errors scenario Sep 18, 2024
@shindigira shindigira changed the title [e2e] Verify a downloaded report after a Syntax Errors scenario [e2e] Verify a downloaded report after a Syntax/Logic Errors scenario Sep 18, 2024
@shindigira shindigira changed the title [e2e] Verify a downloaded report after a Syntax/Logic Errors scenario [e2e] Verify a downloadable report Sep 19, 2024
@shindigira shindigira changed the base branch from 777-all-syntax-errors-again to main September 19, 2024 19:44
@shindigira shindigira changed the title [e2e] Verify a downloadable report [e2e] Tests for syntax errors, logic errors and to verify a downloadable report Sep 19, 2024
@shindigira shindigira changed the title [e2e] Tests for syntax errors, logic errors and to verify a downloadable report [e2e] [Upload] Tests for syntax errors, logic errors and to verify a downloadable report Sep 19, 2024
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can modify/improve Omar's uploadFile.ts for these upload tests? It would be great to have a centralized place for uploading logic if it makes sense to do so.

@shindigira
Copy link
Contributor Author

Do you think we can modify/improve Omar's uploadFile.ts for these upload tests? It would be great to have a centralized place for uploading logic if it makes sense to do so.

Updated the uploadFile.ts to be DRY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants