Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dependabot): disable update PR till e2e coverage is completed #959

Merged
merged 4 commits into from
Sep 20, 2024
Merged

fix(dependabot): disable update PR till e2e coverage is completed #959

merged 4 commits into from
Sep 20, 2024

Conversation

billhimmelsbach
Copy link
Contributor

@billhimmelsbach billhimmelsbach commented Sep 20, 2024 •
edited
Loading

Changes

  • prevents opening new minor dep update PRs by dependabot until we feel good about the e2e coverage and it's running on Dev (we'll still get the security updates, this only applies to the deluge of minor updates we get)

Closes #835

How to test this PR

  1. After this is merged, do you see less dependabot updates?

shindigira
shindigira approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No dependabot spam for a while 🗡️

Reference: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#open-pull-requests-limit

@billhimmelsbach billhimmelsbach enabled auto-merge (squash) September 20, 2024 20:01
@billhimmelsbach billhimmelsbach merged commit 7e77b1e into main Sep 20, 2024
4 checks passed
@billhimmelsbach billhimmelsbach deleted the 835-disable-pr-updates-till-e2e-coverage-is-ready branch September 20, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shindigira shindigira shindigira approved these changes

@meissadia meissadia Awaiting requested review from meissadia meissadia is a code owner

@ojbravo ojbravo Awaiting requested review from ojbravo ojbravo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(dependabot): reduce dependabot level to security fixes only
2 participants
@billhimmelsbach @shindigira