Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: [TextInput] Add a default max length based on input type #988

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Draft: [TextInput] Add a default max length based on input type #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b5eae5
Initial implementation of default overridable limits
tanner-ricks Oct 4, 2024
477958b
switched rerender handling methodology to useMemo and linter make happy
tanner-ricks Oct 4, 2024
5254116
Added more tests
tanner-ricks Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions e2e/pages/filing-app/complete-user-profile/checkCupFormErrors.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import { expect } from '@playwright/test';
import { test } from '../../../fixtures/testFixture';
import { DefaultInputCharLimit } from 'utils/constants';
import { assertTextInput } from '../../../utils/inputValidators';
import { controlUnicode } from '../../../utils/unicodeConstants';

test('Complete the User Profile: Checking for form errors based on user input', async ({
page,
Expand Down Expand Up @@ -33,3 +36,40 @@ test('Complete the User Profile: Checking for form errors based on user input',
);
});
});

test('Complete the User Profile: Checking for input length restriction', async ({
page,
}) => {
test.slow();

await test.step('Complete the User Profile: Check that the error header render when no input is filled', async () => {
await page.getByLabel('Submit User Profile').click();
await expect(page.locator('#step1FormErrorHeader div').first()).toBeVisible(
{
timeout: 30_000,
},
);
});

await test.step('Complete the User Profile: Check the first and last names for invalid input', async () => {
const expectedValues = {
firstField: controlUnicode.slice(0, DefaultInputCharLimit),
lastField: controlUnicode.slice(0, DefaultInputCharLimit),
};
const unexpectedValues = {
firstField: controlUnicode,
lastField: controlUnicode,
};

await assertTextInput(page, 'First name', {
fill: controlUnicode,
expected: expectedValues.firstField,
unexpected: unexpectedValues.firstField,
});
await assertTextInput(page, 'Last name', {
fill: controlUnicode,
expected: expectedValues.lastField,
unexpected: unexpectedValues.lastField,
});
});
});
141 changes: 141 additions & 0 deletions e2e/pages/filing-app/point-of-contact/checkPocFormErrors.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
import { expect } from '@playwright/test';
import { test } from '../../../fixtures/testFixture';
import { controlUnicode } from '../../../utils/unicodeConstants';
import {
assertTextInput,
assertSelectInput,
} from '../../../utils/inputValidators';
import {
DefaultInputCharLimit,
PhoneInputCharLimit,
EmailInputCharLimit,
ZipInputCharLimit,
} from 'utils/constants';

test('Point of Contact: Checking for form errors based on user input', async ({
page,
Expand Down Expand Up @@ -37,3 +48,133 @@ test('Point of Contact: Checking for form errors based on user input', async ({
);
});
});

test('Point of Contact: Checking for unicode tolerance based on user input', async ({
page,
navigateToProvidePointOfContact,
}) => {
test.slow();

navigateToProvidePointOfContact;

await test.step('Point of Contact: Check that the error header render when no input is filled', async () => {
await page.getByRole('button', { name: 'Continue to next step' }).click();
await expect(
page.locator('#PointOfContactFormErrors div').first(),
).toBeVisible();
});

await test.step('Point of Contact: Check the first and last names for invalid input', async () => {
const expectedValues = {
firstField: controlUnicode.slice(0, DefaultInputCharLimit),
lastField: controlUnicode.slice(0, DefaultInputCharLimit),
phoneField: controlUnicode.slice(0, PhoneInputCharLimit),
extensionField: controlUnicode.slice(0, DefaultInputCharLimit),
emailField: controlUnicode.slice(0, EmailInputCharLimit),
addressField1: controlUnicode.slice(0, DefaultInputCharLimit),
addressField2: controlUnicode.slice(0, DefaultInputCharLimit),
addressField3: controlUnicode.slice(0, DefaultInputCharLimit),
addressField4: controlUnicode.slice(0, DefaultInputCharLimit),
cityField: controlUnicode.slice(0, DefaultInputCharLimit),
stateField: 'TX',
zipField: controlUnicode.slice(0, ZipInputCharLimit),
};
const unexpectedValues = {
firstField: controlUnicode,
lastField: controlUnicode,
phoneField: controlUnicode,
extensionField: controlUnicode,
emailField: controlUnicode,
addressField1: controlUnicode,
addressField2: controlUnicode,
addressField3: controlUnicode,
addressField4: controlUnicode,
cityField: controlUnicode,
stateField: '',
zipField: controlUnicode,
};

await assertTextInput(page, 'First name', {
fill: controlUnicode,
expected: expectedValues.firstField,
unexpected: unexpectedValues.firstField,
});
await assertTextInput(page, 'Last name', {
fill: controlUnicode,
expected: expectedValues.lastField,
unexpected: unexpectedValues.lastField,
});
await assertTextInput(page, 'Phone number', {
fill: controlUnicode,
expected: expectedValues.phoneField,
unexpected: unexpectedValues.phoneField,
});
await assertTextInput(page, 'Extension', {
fill: controlUnicode,
expected: expectedValues.extensionField,
unexpected: unexpectedValues.extensionField,
});
await assertTextInput(page, 'Email address', {
fill: controlUnicode,
expected: expectedValues.emailField,
unexpected: unexpectedValues.emailField,
});
await assertTextInput(page, 'Street address line 1', {
fill: controlUnicode,
expected: expectedValues.addressField1,
unexpected: unexpectedValues.addressField1,
});
await assertTextInput(page, 'Street address line 2', {
fill: controlUnicode,
expected: expectedValues.addressField2,
unexpected: unexpectedValues.addressField2,
});
await assertTextInput(page, 'Street address line 3', {
fill: controlUnicode,
expected: expectedValues.addressField3,
unexpected: unexpectedValues.addressField3,
});
await assertTextInput(page, 'Street address line 4', {
fill: controlUnicode,
expected: expectedValues.addressField4,
unexpected: unexpectedValues.addressField4,
});
await assertTextInput(page, 'City', {
fill: controlUnicode,
expected: expectedValues.cityField,
unexpected: unexpectedValues.cityField,
});
await assertSelectInput(page, 'State or territory', {
fill: { label: 'Texas (TX)' },
expected: expectedValues.stateField,
unexpected: unexpectedValues.stateField,
});
await assertTextInput(page, 'Zip code', {
fill: controlUnicode,
expected: expectedValues.zipField,
unexpected: unexpectedValues.zipField,
});

await page.getByRole('button', { name: 'Continue to next step' }).click();

await expect(page.locator('#PointOfContactFormErrors')).toContainText(
'Enter a valid phone number',
);
await expect(page.locator('#PointOfContactFormErrors')).toContainText(
'Enter a valid email address',
);
await expect(page.locator('#PointOfContactFormErrors')).toContainText(
'Enter a valid ZIP code',
);

await expect(page.locator('form')).toContainText(
'You must enter a valid phone number.',
);
await expect(page.locator('form')).toContainText(
'You must enter a valid email address.',
);
await expect(page.locator('form')).toContainText(
'You must enter a valid ZIP code.',
);
});
});
79 changes: 28 additions & 51 deletions e2e/pages/shared-lending-platform/NonAssociatedUserProfile.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { expect } from '@playwright/test';
import { test } from '../../fixtures/testFixture';
import { controlUnicode } from '../../utils/unicodeConstants';
import { assertTextInput } from '../../utils/inputValidators';
import { DefaultInputCharLimit, LeiInputCharLimit } from 'utils/constants';

const expectedNoAssociationsSummaryUrl =
/\/profile\/complete\/summary\/submitted$/;
Expand Down Expand Up @@ -40,62 +42,37 @@ test('Complete User Profile with Bad Unicode -- No Associations -- process', asy

await test.step('Fillout Complete User Profile (No Associations) with bad unicode and verify values', async () => {
const expectedValues = {
firstField: controlUnicode.slice(0, 255),
lastField: controlUnicode.slice(0, 255),
// TODO: Update with correct value after char limit in place, see:
// https://github.com/cfpb/sbl-frontend/issues/972
finField: controlUnicode,
// TODO: Update with correct value after char limit in place, see:
// https://github.com/cfpb/sbl-frontend/issues/972
leiField: controlUnicode,
firstField: controlUnicode.slice(0, DefaultInputCharLimit),
lastField: controlUnicode.slice(0, DefaultInputCharLimit),
finField: controlUnicode.slice(0, DefaultInputCharLimit),
leiField: controlUnicode.slice(0, LeiInputCharLimit),
};
const unexpectedValues = {
firstField: controlUnicode,
lastField: controlUnicode,
// TODO: Change to controlUnicode after char limit in place, see:
// https://github.com/cfpb/sbl-frontend/issues/972
finField: '',
// TODO: Change to controlUnicode after char limit in place, see:
// https://github.com/cfpb/sbl-frontend/issues/972
leiField: '',
finField: controlUnicode,
leiField: controlUnicode,
};

await page.getByLabel('First name').click();
await page.getByLabel('First name').fill(controlUnicode);

await page.getByLabel('Last name').click();
await page.getByLabel('Last name').fill(controlUnicode);

await page.getByLabel('Financial institution name').click();
await page.getByLabel('Financial institution name').fill(controlUnicode);

await page.getByLabel('Legal Entity Identifier (LEI)').click();
await page.getByLabel('Legal Entity Identifier (LEI)').fill(controlUnicode);

await expect(page.getByLabel('First name')).not.toHaveValue(
unexpectedValues.firstField,
);
await expect(page.getByLabel('Last name')).not.toHaveValue(
unexpectedValues.lastField,
);
await expect(page.getByLabel('Financial institution name')).not.toHaveValue(
unexpectedValues.finField,
);
await expect(
page.getByLabel('Legal Entity Identifier (LEI)'),
).not.toHaveValue(unexpectedValues.leiField);

await expect(page.getByLabel('First name')).toHaveValue(
expectedValues.firstField,
);
await expect(page.getByLabel('Last name')).toHaveValue(
expectedValues.lastField,
);
await expect(page.getByLabel('Financial institution name')).toHaveValue(
expectedValues.finField,
);
await expect(page.getByLabel('Legal Entity Identifier (LEI)')).toHaveValue(
expectedValues.leiField,
);
await assertTextInput(page, 'First name', {
fill: controlUnicode,
expected: expectedValues.firstField,
unexpected: unexpectedValues.firstField,
});
await assertTextInput(page, 'Last name', {
fill: controlUnicode,
expected: expectedValues.lastField,
unexpected: unexpectedValues.lastField,
});
await assertTextInput(page, 'Financial institution name', {
fill: controlUnicode,
expected: expectedValues.finField,
unexpected: unexpectedValues.finField,
});
await assertTextInput(page, 'Legal Entity Identifier (LEI)', {
fill: controlUnicode,
expected: expectedValues.leiField,
unexpected: unexpectedValues.leiField,
});
});
});
Loading