-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable opening files via file browser, and via file picker within the app #459
base: master
Are you sure you want to change the base?
Conversation
Can one of the core team members give me the the permission to test this? |
…t isn't MainActivity
…d do away with the specific no cartridge dialog
ok to test |
@mattford In the last years no one was able or had time to start in the neccessary tasks to move WhereYouGo in the changed Android world. (E.g., file system access with SAF). It is possible, that we integrate your PR in the code base here. |
The translation is done in Crowdin: https://crowdin.com/project/whereyougo. The core language is English. So, all translations are done in Crowdin from the English words. |
@bekuno thanks for the response, I sort of realised after I'd raised this PR that the integration into c:geo had progressed, I'd be happy to support the effort over there in any way I can |
You will find the current information to the c:geo WIG integration at https://github.com/cgeo/cgeo/wiki/Use-the-Draft-Wherigo-Player. |
Description
This PR adds a content filter to allow the app to show in the "open with" dialog in Android, allowing a user to select a GWC file from their downloads folder and select to open it in WhereIGo. A "select file" is also added to the start dialog allowing the user to browse the system for a file to open.
On selecting a file to open, the file is copied to the WhereIGo folder and opened. If a file with the same name already exists there, the copy is skipped and the existing cartridge is opened.
There is a slight limitation in the file picking functionality, because GWC doesn't have a defined mimetype and just shows as application/octet-stream, it is not possible to scope the intent-filter and file picker to just gwc files, therefore WhereIGo will appear as a handler for any file type.
I've changed a few English strings so might need some pointers on how this project handles translation.
Tested on API 28 and 33