Skip to content

Commit

Permalink
removed redundant lines in filter
Browse files Browse the repository at this point in the history
  • Loading branch information
SamJaarsma committed Dec 19, 2023
1 parent c8f0843 commit 667c159
Showing 1 changed file with 16 additions and 13 deletions.
29 changes: 16 additions & 13 deletions proto/cmp/types/v1alpha1/filter.proto
Original file line number Diff line number Diff line change
Expand Up @@ -7,41 +7,44 @@ package cmp.types.v1alpha1;
// ![Diagram](https://storage.googleapis.com/docs-cmp-files/diagrams/proto/cmp/types/v1alpha1/filter.proto.dot.xs.svg)
// [Open Message Diagram](https://storage.googleapis.com/docs-cmp-files/diagrams/proto/cmp/types/v1alpha1/filter.proto.dot.svg)
message Filter {
// Filters can be based on a type of a specific code standard or codes agreed between provider
// and distributor in which case the type can be set to "provider"
// Filters can be based on a type of a specific code standard or codes agreed
// between provider and distributor in which case the type can be set to
// "provider"
//
//
// filters have a code, a type and a value.
// filters for business class, first class or economy flights can be set using filters and IATA codelist
// filters for private, shuttle, speedyshuttle can be based on GlobalTypes or OTA codelist
// filters have a code, a type and a value. filters for business class, first
// class or economy flights can be set using filters and IATA codelist filters for
// private, shuttle, speedyshuttle can be based on GlobalTypes or OTA codelist
// filters for 1st or 2nd class train can be based UIC codes or OTA codelist
// filters can also be set for provider specific codes. However, that makes the implementation
// provider specific which undermines the "connect once, connect to many" replication idea
// filters can also be set for provider specific codes. However, that makes the
// implementation provider specific which undermines the "connect once, connect to
// many" replication idea
//
string filter_code = 1;

// Description of the filter code.
string filter_description = 2;

// A filter type can be set to for example "DRV GlobalTypes", "IATA codes", "UIC codes", "ACRISS codes".
// A filter type can be set to for example "DRV GlobalTypes", "IATA codes", "UIC
// codes", "ACRISS codes".
FilterType filter_type = 3;

// Adding a filter value like for example "star_rating=5" or "row_number=1".
string filter_value = 4;


}

// Filter Type
enum FilterType {
FILTER_TYPE_UNSPECIFIED = 0;
// provider specific codes - discouraged to be used as this increases maintenance of APIs
// provider specific codes - discouraged to be used as this increases maintenance
// of APIs
FILTER_TYPE_PROVIDER_CODE = 1;
// DRV GlobalTypes https://globaltypecenter.com/
FILTER_TYPE_GLOBAL_TYPE = 2;
// International Air Transport Association https://www.iata.org/
FILTER_TYPE_IATA = 3;
// International Civil Aviation Organization, an agency of the UN https://www.icao.int/
// International Civil Aviation Organization, an agency of the UN
// https://www.icao.int/
FILTER_TYPE_ICAO = 4;
// rail standarization of the UIC https://uic.org/standardisation
FILTER_TYPE_UIC = 5;
Expand All @@ -51,4 +54,4 @@ enum FilterType {
FILTER_TYPE_ISO = 7;
// settlement services provider https://www.arccorp.com/
FILTER_TYPE_ARC = 8;
}
}

0 comments on commit 667c159

Please sign in to comment.